lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <bhw5l75erhcci7z55vrcos43qtyn7txsspv6qtazhlulpbn7km@dp6yg6sf2gwk> Date: Tue, 19 Dec 2023 18:53:58 +0300 From: Serge Semin <fancer.lancer@...il.com> To: Lai Peter Jun Ann <jun.ann.lai@...el.com> Cc: Alexandre Torgue <alexandre.torgue@...s.st.com>, Jose Abreu <joabreu@...opsys.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>, netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, Song Yoong Siang <yoong.siang.song@...el.com> Subject: Re: [PATCH net v2 1/1] net: stmmac: fix incorrect flag check in timestamp interrupt On Mon, Dec 18, 2023 at 03:51:32PM +0800, Lai Peter Jun Ann wrote: > The driver should continue get the timestamp if STMMAC_FLAG_EXT_SNAPSHOT_EN > flag is set. > > Fixes: aa5513f5d95f ("net: stmmac: replace the ext_snapshot_en field with a flag") > Cc: <stable@...r.kernel.org> # 6.6 > Signed-off-by: Song Yoong Siang <yoong.siang.song@...el.com> > Signed-off-by: Lai Peter Jun Ann <jun.ann.lai@...el.com> Right. The blamed commit has wrongly converted that conditional statement. Reviewed-by: Serge Semin <fancer.lancer@...il.com> -Serge(y) > --- > v2 changelog: > - Add fix tag and stable@...r.kernel.org in email cc list. > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c > index 540f6a4..f05bd75 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c > @@ -237,7 +237,7 @@ static void timestamp_interrupt(struct stmmac_priv *priv) > */ > ts_status = readl(priv->ioaddr + GMAC_TIMESTAMP_STATUS); > > - if (priv->plat->flags & STMMAC_FLAG_EXT_SNAPSHOT_EN) > + if (!(priv->plat->flags & STMMAC_FLAG_EXT_SNAPSHOT_EN)) > return; > > num_snapshot = (ts_status & GMAC_TIMESTAMP_ATSNS_MASK) >> > -- > 1.9.1 > >
Powered by blists - more mailing lists