lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZYHIRswwTIvmstSH@boxer> Date: Tue, 19 Dec 2023 17:43:50 +0100 From: Maciej Fijalkowski <maciej.fijalkowski@...el.com> To: Tony Nguyen <anthony.l.nguyen@...el.com> CC: <davem@...emloft.net>, <kuba@...nel.org>, <pabeni@...hat.com>, <edumazet@...gle.com>, <netdev@...r.kernel.org>, Larysa Zaremba <larysa.zaremba@...el.com>, <magnus.karlsson@...el.com>, <ast@...nel.org>, <daniel@...earbox.net>, <hawk@...nel.org>, <john.fastabend@...il.com>, <bpf@...r.kernel.org>, Przemek Kitszel <przemyslaw.kitszel@...el.com>, "Simon Horman" <horms@...nel.org>, Chandan Kumar Rout <chandanx.rout@...el.com> Subject: Re: [PATCH net 3/3] ice: Fix PF with enabled XDP going no-carrier after reset On Mon, Dec 18, 2023 at 11:27:06AM -0800, Tony Nguyen wrote: > From: Larysa Zaremba <larysa.zaremba@...el.com> > > Commit 6624e780a577fc596788 ("ice: split ice_vsi_setup into smaller > functions") has refactored a bunch of code involved in PFR. In this > process, TC queue number adjustment for XDP was lost. Bring it back. > > Lack of such adjustment causes interface to go into no-carrier after a > reset, if XDP program is attached, with the following message: > > ice 0000:b1:00.0: Failed to set LAN Tx queue context, error: -22 > ice 0000:b1:00.0 ens801f0np0: Failed to open VSI 0x0006 on switch 0x0001 > ice 0000:b1:00.0: enable VSI failed, err -22, VSI index 0, type ICE_VSI_PF > ice 0000:b1:00.0: PF VSI rebuild failed: -22 > ice 0000:b1:00.0: Rebuild failed, unload and reload driver > > Fixes: 6624e780a577 ("ice: split ice_vsi_setup into smaller functions") > Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com> > Signed-off-by: Larysa Zaremba <larysa.zaremba@...el.com> > Reviewed-by: Simon Horman <horms@...nel.org> > Tested-by: Chandan Kumar Rout <chandanx.rout@...el.com> (A Contingent Worker at Intel) > Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com> > --- > drivers/net/ethernet/intel/ice/ice_lib.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c > index de7ba87af45d..1bad6e17f9be 100644 > --- a/drivers/net/ethernet/intel/ice/ice_lib.c > +++ b/drivers/net/ethernet/intel/ice/ice_lib.c > @@ -2371,6 +2371,9 @@ static int ice_vsi_cfg_tc_lan(struct ice_pf *pf, struct ice_vsi *vsi) > } else { > max_txqs[i] = vsi->alloc_txq; > } > + > + if (vsi->type == ICE_VSI_PF) > + max_txqs[i] += vsi->num_xdp_txq; Nit: typically we always preceded this with ice_is_xdp_ena_vsi() call. However, in this case I suppose it doesn't matter much, as if XDP prog is not present then this value will just be 0. Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com> > } > > dev_dbg(dev, "vsi->tc_cfg.ena_tc = %d\n", vsi->tc_cfg.ena_tc); > -- > 2.41.0 >
Powered by blists - more mailing lists