netdev - Re: [PATCH V3 net-next 4/4] net: hns3: move constants from hclge_debugfs.h to hclge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5fa71441-a3c0-46ee-802d-5b08492f4e8f@huawei.com>
Date: Tue, 19 Dec 2023 09:45:03 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: Simon Horman <horms@...nel.org>
CC: <shaojijie@...wei.com>, <yisen.zhuang@...wei.com>,
	<salil.mehta@...wei.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <shenjian15@...wei.com>,
	<wangjie125@...wei.com>, <liuyonglong@...wei.com>, <lanhao@...wei.com>,
	<wangpeiyang1@...wei.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V3 net-next 4/4] net: hns3: move constants from
 hclge_debugfs.h to hclge_debugfs.c


on 2023/12/18 23:35, Simon Horman wrote:
> On Sat, Dec 16, 2023 at 03:00:18PM +0800, Jijie Shao wrote:
>> some constants are defined in hclge_debugfs.h,
>> but only used in hclge_debugfs.c.
>> so move them from hclge_debugfs.h to hclge_debugfs.c.
>>
>> Signed-off-by: Jijie Shao <shaojijie@...wei.com>
> Thanks Jijie,
>
> this looks good, but I think it should come before patch 2/4,
> to avoid warnings about unused symbols being flagged until this patch is
> applied.
>
> ...

Thanks for your suggestion, this will be fixed in v4.