netdev - Re: [PATCH net] net/ipv6: Revert remove expired routes with a separated list of routes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c3ae9c3a-9ecd-4b22-a908-9da587c1c88b@kernel.org>
Date: Mon, 18 Dec 2023 19:38:13 -0700
From: David Ahern <dsahern@...nel.org>
To: Kui-Feng Lee <sinquersw@...il.com>, netdev@...r.kernel.org
Cc: edumazet@...gle.com, Kui-Feng Lee <thinker.li@...il.com>
Subject: Re: [PATCH net] net/ipv6: Revert remove expired routes with a
 separated list of routes

On 12/18/23 6:14 PM, Kui-Feng Lee wrote:
> 
> 
> On 12/17/23 10:55, David Ahern wrote:
>> Revert the remainder of 5a08d0065a915 which added a warn on if a fib
>> entry is still on the gc_link list, and then revert  all of the commit
>> in the Fixes tag. The commit has some race conditions given how expires
>> is managed on a fib6_info in relation to timer start, adding the entry
>> to the gc list and setting the timer value leading to UAF. Revert
>> the commit and try again in a later release.
> 
> May I know what your concerns are about the patch I provided?
> Even I try it again later, I still need to know what I miss and should
> address.

This is a judgement call based on 6.7-rc number and upcoming holidays
with people offline. A bug fix is needed for a performance optimization;
the smart response here is to revert the patch and try again after the
holidays.