[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <62d80fec-8de4-4719-b244-86b26954d723@infradead.org>
Date: Mon, 18 Dec 2023 20:31:31 -0800
From: Randy Dunlap <rdunlap@...radead.org>
To: Jonathan Corbet <corbet@....net>, Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: skbuff: Remove some excess struct-member
documentation
On 12/18/23 16:26, Jonathan Corbet wrote:
> Remove documentation for nonexistent structure members, addressing these
> warnings:
>
> ./include/linux/skbuff.h:1063: warning: Excess struct member 'sp' description in 'sk_buff'
> ./include/linux/skbuff.h:1063: warning: Excess struct member 'nf_bridge' description in 'sk_buff'
>
> Signed-off-by: Jonathan Corbet <corbet@....net>
Reviewed-by: Randy Dunlap <rdunlap@...radead.org>
Thanks.
> ---
> include/linux/skbuff.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> index 27998f73183e..1cdab90a10a2 100644
> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -742,7 +742,6 @@ typedef unsigned char *sk_buff_data_t;
> * @dev_scratch: (aka @dev) alternate use of @dev when @dev would be %NULL
> * @cb: Control buffer. Free for use by every layer. Put private vars here
> * @_skb_refdst: destination entry (with norefcount bit)
> - * @sp: the security path, used for xfrm
> * @len: Length of actual data
> * @data_len: Data length
> * @mac_len: Length of link layer header
> @@ -776,7 +775,6 @@ typedef unsigned char *sk_buff_data_t;
> * @tcp_tsorted_anchor: list structure for TCP (tp->tsorted_sent_queue)
> * @_sk_redir: socket redirection information for skmsg
> * @_nfct: Associated connection, if any (with nfctinfo bits)
> - * @nf_bridge: Saved data about a bridged frame - see br_netfilter.c
> * @skb_iif: ifindex of device we arrived on
> * @tc_index: Traffic control index
> * @hash: the packet hash
--
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html
Powered by blists - more mailing lists