lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ee1112af-cb13-483b-b6b5-4489a39c57cc@linux.intel.com> Date: Tue, 19 Dec 2023 09:57:46 +0200 From: "naamax.meir" <naamax.meir@...ux.intel.com> To: Jesse Brandeburg <jesse.brandeburg@...el.com>, intel-wired-lan@...ts.osuosl.org Cc: przemyslaw.kitszel@...el.com, aleksander.lobakin@...el.com, marcin.szycik@...ux.intel.com, horms@...nel.org, netdev@...r.kernel.org Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2 01/15] e1000e: make lost bits explicit On 12/6/2023 03:01, Jesse Brandeburg wrote: > For more than 15 years this code has passed in a request for a page and > masked off that page when read/writing. This code has been here forever, > but FIELD_PREP finds the bug when converted to use it. Change the code > to do exactly the same thing but allow the conversion to FIELD_PREP in a > later patch. To make it clear what we lost when making this change I > left a comment, but there is no point to change the code to generate a > correct sequence at this point. > > This is not a Fixes tagged patch on purpose because it doesn't change > the binary output. > > Reviewed-by: Marcin Szycik <marcin.szycik@...ux.intel.com> > Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com> > --- > drivers/net/ethernet/intel/e1000e/80003es2lan.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) Tested-by: Naama Meir <naamax.meir@...ux.intel.com>
Powered by blists - more mailing lists