netdev - Re: [lvc-project] [PATCH] linux-5.19.y: net: fddi: skfp: Uninitialized data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <c68bc048-3a57-c95b-dae5-555284ec2122@ispras.ru>
Date: Tue, 19 Dec 2023 12:22:45 +0300
From: Alexey Khoroshilov <khoroshilov@...ras.ru>
To: Александр C <alsp705@...il.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 lvc-project@...uxtesting.org
Subject: Re: [lvc-project] [PATCH] linux-5.19.y: net: fddi: skfp:
 Uninitialized data

Dear Alexander,

On 19.12.2023 12:00, Александр C wrote:
> Uninitialized data is read from local variable 'word_val' at pmf.c:1302.
> 
> Found by Linux Verification Center (linuxtesting.org
> <http://linuxtesting.org>) with SVACE.
> 
> Signed-off-by: Alexander Sapozhnikov <alsp705@...il.com
> <mailto:alsp705@...il.com>>
> ---
>  drivers/net/fddi/skfp/pmf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/fddi/skfp/pmf.c b/drivers/net/fddi/skfp/pmf.c
> index 563fb7f0b327..3f24fbd82a73 100644
> --- a/drivers/net/fddi/skfp/pmf.c
> +++ b/drivers/net/fddi/skfp/pmf.c
> @@ -1084,7 +1084,7 @@ static int smt_set_para(struct s_smc *smc, struct
> smt_para *pa, int index,
>   int path ;
>   int port ;
>   SK_LOC_DECL(u_char,byte_val) ;
> - SK_LOC_DECL(u_short,word_val) ;
> + SK_LOC_DECL(u_short, word_val) = 0 ;
>   SK_LOC_DECL(u_long,long_val) ;
>  
>   mac = index - INDEX_MAC ;
> -- 

Something is broken with your e-mail settings. The mail is in HTML, not
in plain text.

Have you used git send-email to send the patch?

--
Alexey