netdev - Re: [PATCH v1] ptp: ocp: fix bug in unregistering the DPLL subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b34ebe86-c3bd-48ea-b76b-7b778cc7c086@linux.dev>
Date: Wed, 20 Dec 2023 10:22:37 +0000
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Sagi Maimon <maimon.sagi@...il.com>, richardcochran@...il.com,
 jonathan.lemon@...il.com, vadfed@...com, jiri@...nulli.us,
 arkadiusz.kubalewski@...el.com, davem@...emloft.net
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH v1] ptp: ocp: fix bug in unregistering the DPLL subsystem

On 20/12/2023 08:19, Sagi Maimon wrote:
> When unregistering the DPLL subsystem the priv pointer is different then
> the one used for registration which cause failure in unregistering.
> 
> Fixes: 09eeb3aecc6c ("ptp_ocp: implement DPLL ops")
> ---
>   drivers/ptp/ptp_ocp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c
> index 4021d3d325f9..e7defce8cf48 100644
> --- a/drivers/ptp/ptp_ocp.c
> +++ b/drivers/ptp/ptp_ocp.c
> @@ -4492,7 +4492,7 @@ ptp_ocp_remove(struct pci_dev *pdev)
>   	cancel_delayed_work_sync(&bp->sync_work);
>   	for (i = 0; i < OCP_SMA_NUM; i++) {
>   		if (bp->sma[i].dpll_pin) {
> -			dpll_pin_unregister(bp->dpll, bp->sma[i].dpll_pin, &dpll_pins_ops, bp);
> +			dpll_pin_unregister(bp->dpll, bp->sma[i].dpll_pin, &dpll_pins_ops, &bp->sma[i]);
>   			dpll_pin_put(bp->sma[i].dpll_pin);
>   		}
>   	}

Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>