lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <f43f77f9-416b-4ef6-9def-f0dd1b7a3efb@linux.ibm.com> Date: Wed, 20 Dec 2023 11:27:45 +0100 From: Alexandra Winter <wintera@...ux.ibm.com> To: Wen Gu <guwen@...ux.alibaba.com>, wenjia@...ux.ibm.com, hca@...ux.ibm.com, gor@...ux.ibm.com, agordeev@...ux.ibm.com, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, kgraul@...ux.ibm.com, jaka@...ux.ibm.com Cc: borntraeger@...ux.ibm.com, svens@...ux.ibm.com, alibuda@...ux.alibaba.com, tonylu@...ux.alibaba.com, raspl@...ux.ibm.com, schnelle@...ux.ibm.com, guangguan.wang@...ux.alibaba.com, linux-s390@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH net-next v8 03/10] net/smc: unify the structs of accept or confirm message for v1 and v2 On 19.12.23 15:26, Wen Gu wrote: > The structs of CLC accept and confirm messages for SMCv1 and SMCv2 are > separately defined and often casted to each other in the code, which may > increase the risk of errors caused by future divergence of them. So > unify them into one struct for better maintainability. > > Suggested-by: Alexandra Winter <wintera@...ux.ibm.com> > Signed-off-by: Wen Gu <guwen@...ux.alibaba.com> > --- > net/smc/af_smc.c | 52 +++++++++++++------------------------ > net/smc/smc_clc.c | 65 ++++++++++++++++++++--------------------------- > net/smc/smc_clc.h | 42 +++++++++++++----------------- > 3 files changed, 62 insertions(+), 97 deletions(-) Thanks a lot Wen Gu, I really love this. Using an unnamed union is a great solution here. Now the code is so much more readable and maintainable Reviewed-by: Alexandra Winter <wintera@...ux.ibm.com>
Powered by blists - more mailing lists