lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20231220-drillen-obskur-a310578e99bb@brauner> Date: Wed, 20 Dec 2023 13:10:10 +0100 From: Christian Brauner <brauner@...nel.org> To: Andrii Nakryiko <andrii@...nel.org> Cc: bpf@...r.kernel.org, netdev@...r.kernel.org, torvalds@...uxfoundation.org, ast@...nel.org, daniel@...earbox.net, linux-fsdevel@...r.kernel.org, kernel-team@...a.com Subject: Re: [PATCH bpf-next] bpf: add BPF_F_TOKEN_FD flag to pass with BPF token FD On Mon, Dec 18, 2023 at 09:31:50PM -0800, Andrii Nakryiko wrote: > Add BPF_F_TOKEN_FD flag to be used across bpf() syscall commands > that accept BPF token FD: BPF_PROG_LOAD, BPF_MAP_CREATE, and > BPF_BTF_LOAD. This flag has to be set whenever token FD is provided. > > BPF_BTF_LOAD command didn't have a flags field, so add it as well. > > Signed-off-by: Andrii Nakryiko <andrii@...nel.org> > --- Reviewed-by: Christian Brauner <brauner@...nel.org> > /* Get path from provided FD in BPF_OBJ_PIN/BPF_OBJ_GET commands */ > BPF_F_PATH_FD = (1U << 14), > + > +/* BPF token FD is passed in a corresponding command's token_fd field */ > + BPF_F_TOKEN_FD = (1U << 15), The placement of the new flag right after the BPF_F_PATH_FD flag alone does tell us everything about the "we didn't know" claims wrt to the token fd stuff. Literally the same review and the same solution I requested back then.
Powered by blists - more mailing lists