netdev - Re: [RFC nf-next v2 1/2] netfilter: bpf: support prog update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b3614748-e34e-5629-e483-ddff29af8fe4@linux.alibaba.com>
Date: Wed, 20 Dec 2023 20:40:19 +0800
From: "D. Wythe" <alibuda@...ux.alibaba.com>
To: Florian Westphal <fw@...len.de>
Cc: Simon Horman <horms@...nel.org>, pablo@...filter.org,
 kadlec@...filter.org, bpf@...r.kernel.org, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org, coreteam@...filter.org,
 netfilter-devel@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, ast@...nel.org
Subject: Re: [RFC nf-next v2 1/2] netfilter: bpf: support prog update

On 12/19/23 10:58 PM, Florian Westphal wrote:
> D. Wythe <alibuda@...ux.alibaba.com> wrote:
>> net/netfilter/nf_bpf_link.c:31:22: note: in expansion of macro
>> ‘rcu_dereference’
>>     31 |  return bpf_prog_run(rcu_dereference((const struct bpf_prog __rcu
>> *)nf_link->link.prog), &ctx);
>>        |                      ^~~~~~~~~~~~~~~
>>
>> So, I think we might need to go back to version 1.
>>
>> @ Florian , what do you think ?
> Use rcu_dereference_raw().

Got it. I'm also good with that.

D. Wythe