[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <w2xqtfeafqxkbocemv3u7p6gfwib2kad2tjbfzlf7d22uvopnq@4a2zktggci3o>
Date: Wed, 20 Dec 2023 13:57:41 +0000
From: Alvin Šipraga <ALSI@...g-olufsen.dk>
To: Luiz Angelo Daros de Luca <luizluca@...il.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linus.walleij@...aro.org" <linus.walleij@...aro.org>, "andrew@...n.ch"
<andrew@...n.ch>, "f.fainelli@...il.com" <f.fainelli@...il.com>,
"olteanv@...il.com" <olteanv@...il.com>, "davem@...emloft.net"
<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
"arinc.unal@...nc9.com" <arinc.unal@...nc9.com>
Subject: Re: [PATCH net-next v2 1/7] net: dsa: realtek: drop cleanup from
realtek_ops
On Wed, Dec 20, 2023 at 01:24:24AM -0300, Luiz Angelo Daros de Luca wrote:
> It was never used and never referenced.
>
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@...il.com>
> Reviewed-by: Alvin Šipraga <alsi@...g-olufsen.dk>
You should always put your Signed-off-by last when sending patches.
> ---
> drivers/net/dsa/realtek/realtek.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/dsa/realtek/realtek.h b/drivers/net/dsa/realtek/realtek.h
> index 790488e9c667..e9ee778665b2 100644
> --- a/drivers/net/dsa/realtek/realtek.h
> +++ b/drivers/net/dsa/realtek/realtek.h
> @@ -91,7 +91,6 @@ struct realtek_ops {
> int (*detect)(struct realtek_priv *priv);
> int (*reset_chip)(struct realtek_priv *priv);
> int (*setup)(struct realtek_priv *priv);
> - void (*cleanup)(struct realtek_priv *priv);
> int (*get_mib_counter)(struct realtek_priv *priv,
> int port,
> struct rtl8366_mib_counter *mib,
> --
> 2.43.0
>
Powered by blists - more mailing lists