netdev - Re: [PATCH net-next v3 5/8] dpaa2-switch: do not clear any interrupts automatically

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231220144822.GJ882741@kernel.org>
Date: Wed, 20 Dec 2023 15:48:22 +0100
From: Simon Horman <horms@...nel.org>
To: Ioana Ciornei <ioana.ciornei@....com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3 5/8] dpaa2-switch: do not clear any
 interrupts automatically

On Tue, Dec 19, 2023 at 01:59:30PM +0200, Ioana Ciornei wrote:
> The DPSW object has multiple event sources multiplexed over the same
> IRQ. The driver has the capability to configure only some of these
> events to trigger the IRQ.
> 
> The dpsw_get_irq_status() can clear events automatically based on the
> value stored in the 'status' variable passed to it. We don't want that
> to happen because we could get into a situation when we are clearing
> more events than we actually handled.
> 
> Just resort to manually clearing the events that we handled. Also, since
> status is not used on the out path we remove its initialization to zero.
> 
> This change does not have a user-visible effect because the dpaa2-switch
> driver enables and handles all the DPSW events which exist at the
> moment.
> 
> Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>
> ---
> Changes in v3:
> - mention that the change does not have a user visible impact
> Changes in v2:
> - add a bit more info in the commit message

Thanks for these updates too.

Reviewed-by: Simon Horman <horms@...nel.org>