netdev - Re: [PATCH net-next 13/15] net: phy: realtek: drop .read_page and .write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cb28278d-c038-4dbf-81e7-097bf61dfb74@gmail.com>
Date: Wed, 20 Dec 2023 18:23:21 +0100
From: Heiner Kallweit <hkallweit1@...il.com>
To: Marek Behún <kabel@...nel.org>, netdev@...r.kernel.org,
 Andrew Lunn <andrew@...n.ch>, "David S. Miller" <davem@...emloft.net>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: Russell King <rmk+kernel@...linux.org.uk>,
 Alexander Couzens <lynxis@...0.eu>, Daniel Golle <daniel@...rotopia.org>,
 Willy Liu <willy.liu@...ltek.com>, Ioana Ciornei <ioana.ciornei@....com>,
 Marek Mojík <marek.mojik@....cz>,
 Maximilián Maliar <maximilian.maliar@....cz>
Subject: Re: [PATCH net-next 13/15] net: phy: realtek: drop .read_page and
 .write_page for rtl822x series

On 20.12.2023 16:55, Marek Behún wrote:
> Drop the .read_page() and .write_page() methods for rtl822x series.
> 
> The rtl822x driver methods are now reimplemented to only access clause
> 45 registers and these are the last methods that explicitly access
> clause 22 registers.
> 
> If the underlying MDIO bus is clause 22, the paging mechanism is still
> used internally in the .read_mmd() and .write_mmd() methods when
> accessing registers in MMD 31.
> 
> Signed-off-by: Marek Behún <kabel@...nel.org>
> ---
>  drivers/net/phy/realtek.c | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
> index cf608d390aa5..e2f68ac4b005 100644
> --- a/drivers/net/phy/realtek.c
> +++ b/drivers/net/phy/realtek.c
> @@ -963,8 +963,6 @@ static struct phy_driver realtek_drvs[] = {
>  		.read_status	= rtl822x_read_status,
>  		.suspend	= genphy_c45_pma_suspend,
>  		.resume		= rtl822x_resume,
> -		.read_page	= rtl821x_read_page,
> -		.write_page	= rtl821x_write_page,
>  		.read_mmd	= rtlgen_read_mmd,
>  		.write_mmd	= rtlgen_write_mmd,
>  	}, {
> @@ -975,8 +973,6 @@ static struct phy_driver realtek_drvs[] = {
>  		.read_status	= rtl822x_read_status,
>  		.suspend	= genphy_c45_pma_suspend,
>  		.resume		= rtl822x_resume,
> -		.read_page	= rtl821x_read_page,
> -		.write_page	= rtl821x_write_page,
>  		.read_mmd	= rtlgen_read_mmd,
>  		.write_mmd	= rtlgen_write_mmd,
>  	}, {
> @@ -987,8 +983,6 @@ static struct phy_driver realtek_drvs[] = {
>  		.read_status    = rtl822x_read_status,
>  		.suspend	= genphy_c45_pma_suspend,
>  		.resume		= rtl822x_resume,
> -		.read_page      = rtl821x_read_page,
> -		.write_page     = rtl821x_write_page,
>  		.read_mmd	= rtlgen_read_mmd,
>  		.write_mmd	= rtlgen_write_mmd,
>  	}, {
> @@ -999,8 +993,6 @@ static struct phy_driver realtek_drvs[] = {
>  		.read_status    = rtl822x_read_status,
>  		.suspend	= genphy_c45_pma_suspend,
>  		.resume		= rtl822x_resume,
> -		.read_page      = rtl821x_read_page,
> -		.write_page     = rtl821x_write_page,
>  		.read_mmd	= rtlgen_read_mmd,
>  		.write_mmd	= rtlgen_write_mmd,
>  	}, {
> @@ -1011,8 +1003,6 @@ static struct phy_driver realtek_drvs[] = {
>  		.read_status    = rtl822x_read_status,
>  		.suspend	= genphy_c45_pma_suspend,
>  		.resume		= rtl822x_resume,
> -		.read_page      = rtl821x_read_page,
> -		.write_page     = rtl821x_write_page,
>  		.read_mmd	= rtlgen_read_mmd,
>  		.write_mmd	= rtlgen_write_mmd,
>  	}, {
> @@ -1023,8 +1013,6 @@ static struct phy_driver realtek_drvs[] = {
>  		.read_status    = rtl822x_read_status,
>  		.suspend	= genphy_c45_pma_suspend,
>  		.resume		= rtl822x_resume,
> -		.read_page      = rtl821x_read_page,
> -		.write_page     = rtl821x_write_page,
>  		.read_mmd	= rtlgen_read_mmd,
>  		.write_mmd	= rtlgen_write_mmd,
>  	}, {

Dropping the read_page/write_page hooks will be problematic,
because they are used by the PHY initialization in e.g.
rtl8125a_2_hw_phy_config().