netdev - Re: [PATCH V2 07/12 net-next] qca_spi: Introduce QCASPI_RX_MAX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a24f00ed-460c-4ba2-bcf9-c767aacda70c@intel.com>
Date: Wed, 20 Dec 2023 14:26:34 -0800
From: Jacob Keller <jacob.e.keller@...el.com>
To: Stefan Wahren <wahrenst@....net>, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, "Paolo
 Abeni" <pabeni@...hat.com>
CC: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2 07/12 net-next] qca_spi: Introduce QCASPI_RX_MAX_FRAMES



On 12/18/2023 3:26 PM, Stefan Wahren wrote:
> Currently qca_spi reserves enough space for 4 complete Ethernet over SPI
> frames in the receive buffer. Unfortunately this is hidden under a magic
> number. So replace it with a more self explaining define.
> 

Yea, this is lot more descriptive to say "RX_MAX_FRAMES", rather than
just 4.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

> Signed-off-by: Stefan Wahren <wahrenst@....net>
> ---