netdev - Re: [PATCH V2 10/12 net-next] qca_spi: Adjust log of SPI_REG_RDBUF_BYTE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <115635f1-584e-4db8-ab41-2c0e10e8b784@intel.com>
Date: Wed, 20 Dec 2023 15:02:04 -0800
From: Jacob Keller <jacob.e.keller@...el.com>
To: Stefan Wahren <wahrenst@....net>, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, "Paolo
 Abeni" <pabeni@...hat.com>
CC: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2 10/12 net-next] qca_spi: Adjust log of
 SPI_REG_RDBUF_BYTE_AVA



On 12/18/2023 3:26 PM, Stefan Wahren wrote:
> All known SPI registers of the QCA700x are 16 bit long. So adjust
> the formater width accordingly.
> 
> Signed-off-by: Stefan Wahren <wahrenst@....net>
> ---
>  drivers/net/ethernet/qualcomm/qca_spi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c
> index c5d240fe4146..d3109eb24b4d 100644
> --- a/drivers/net/ethernet/qualcomm/qca_spi.c
> +++ b/drivers/net/ethernet/qualcomm/qca_spi.c
> @@ -359,7 +359,7 @@ qcaspi_receive(struct qcaspi *qca)
>  	/* Read the packet size. */
>  	qcaspi_read_register(qca, SPI_REG_RDBUF_BYTE_AVA, &available);
> 
> -	netdev_dbg(net_dev, "qcaspi_receive: SPI_REG_RDBUF_BYTE_AVA: Value: %08x\n",
> +	netdev_dbg(net_dev, "qcaspi_receive: SPI_REG_RDBUF_BYTE_AVA: Value: %04x\n",
>  		   available);
> 

Sure, no reason to show 0x0000FFFF when just 0xFFFF would be sufficient.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

>  	if (available > QCASPI_HW_BUF_LEN + QCASPI_HW_PKT_LEN) {
> --
> 2.34.1
> 
>