[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0ecaa500-9dbf-48e1-97a9-13ba7c2563ae@intel.com>
Date: Wed, 20 Dec 2023 15:05:01 -0800
From: Jacob Keller <jacob.e.keller@...el.com>
To: Stefan Wahren <wahrenst@....net>, "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, "Paolo
Abeni" <pabeni@...hat.com>
CC: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2 01/12 net-next] qca_spi: Improve SPI thread creation
On 12/18/2023 3:26 PM, Stefan Wahren wrote:
> The qca_spi driver create/stop the SPI kernel thread in case
> of netdev_open/close. This isn't optimal because there is no
> need for such an expensive operation.
>
> So improve this by moving create/stop of the SPI kernel into
> the init/uninit ops. The open/close ops could just
> 'park/unpark' the SPI kernel thread.
>
If I understand, this is also important because kthread_stop would
ultimately result in the task being destroyed and thus user space
configuration of the task (priority, pinning, etc) would be lost too.
Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
Powered by blists - more mailing lists