netdev - Re: [PATCH net-next 00/15][pull request] intel: use bitfield operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <756f09cf-0573-8391-fa90-0e74678d2aff@intel.com>
Date: Wed, 20 Dec 2023 10:35:57 +0100
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: "Nelson, Shannon" <shannon.nelson@....com>, Tony Nguyen
	<anthony.l.nguyen@...el.com>, <davem@...emloft.net>, <kuba@...nel.org>,
	<pabeni@...hat.com>, <edumazet@...gle.com>, <netdev@...r.kernel.org>
CC: <jesse.brandeburg@...el.com>
Subject: Re: [PATCH net-next 00/15][pull request] intel: use bitfield
 operations

On 12/20/23 02:10, Nelson, Shannon wrote:
> On 12/18/2023 11:48 AM, Tony Nguyen wrote:
>>
>> Jesse Brandeburg says:
>>
>> After repeatedly getting review comments on new patches, and sporadic
>> patches to fix parts of our drivers, we should just convert the Intel 
>> code
>> to use FIELD_PREP() and FIELD_GET().  It's then "common" in the code and
>> hopefully future change-sets will see the context and do-the-right-thing.
>>
>> This conversion was done with a coccinelle script which is mentioned 
>> in the
>> commit messages. Generally there were only a couple conversions that were
>> "undone" after the automatic changes because they tried to convert a
>> non-contiguous mask.
>>
>> Patch 1 is required at the beginning of this series to fix a "forever"
>> issue in the e1000e driver that fails the compilation test after 
>> conversion
>> because the shift / mask was out of range.
>>
>> The second patch just adds all the new #includes in one go.
>>
>> The patch titled: "ice: fix pre-shifted bit usage" is needed to allow the
>> use of the FIELD_* macros and fix up the unexpected "shifts included"
>> defines found while creating this series.
>>
>> The rest are the conversion to use FIELD_PREP()/FIELD_GET(), and the
>> occasional leXX_{get,set,encode}_bits() call, as suggested by Alex.
>>
>> The following are changes since commit 
>> 610a689d2a57af3e21993cb6d8c3e5f839a8c89e:
>>    Merge branch 'rtnl-rcu'
>> and are available in the git repository at:
>>    git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue 1GbE
> 
> 
> Thanks for doing these - this certainly makes it significantly less mind 
> numbing to read all those bitfield things.
> 
> Is there any plan to remove all those xxx_S and xxx_SHIFT defines now? I 
> expect not, but I thought I'd ask.

There are any unused now or 'it just asks for refactor'? :)