netdev - Re: [PATCH net-next] net: sfp: fix PHY discovery for FS SFP-10G-T module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d7e37e48-a557-4dad-91a5-85283dd3fc5f@lunn.ch>
Date: Thu, 21 Dec 2023 11:03:18 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Marek Behún <kabel@...nel.org>
Cc: netdev@...r.kernel.org, Russell King <rmk+kernel@...linux.org.uk>,
	Jakub Kicinski <kuba@...nel.org>, Wei Lei <quic_leiwei@...cinc.com>
Subject: Re: [PATCH net-next] net: sfp: fix PHY discovery for FS SFP-10G-T
 module

On Tue, Dec 19, 2023 at 05:24:15PM +0100, Marek Behún wrote:
> Commit 2f3ce7a56c6e ("net: sfp: rework the RollBall PHY waiting code")
> changed the long wait before accessing RollBall / FS modules into
> probing for PHY every 1 second, and trying 25 times.
> 
> Wei Lei reports that this does not work correctly on FS modules: when
> initializing, they may report values different from 0xffff in PHY ID
> registers for some MMDs, causing get_phy_c45_ids() to find some bogus
> MMD.
> 
> Fix this by adding the module_t_wait member back, and setting it to 4
> seconds for FS modules.
> 
> Fixes: 2f3ce7a56c6e ("net: sfp: rework the RollBall PHY waiting code")
> Reported-by: Wei Lei <quic_leiwei@...cinc.com>
> Signed-off-by: Marek Behún <kabel@...nel.org>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew