netdev - Re: [PATCH net-next v1 1/1] ptp: ocp: Use DEFINE_RES

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e5fb1fa-33a3-470c-b479-24019f322ed3@linux.dev>
Date: Thu, 21 Dec 2023 14:58:53 +0000
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Jonathan Lemon <jonathan.lemon@...il.com>,
 Richard Cochran <richardcochran@...il.com>, Paolo Abeni <pabeni@...hat.com>,
 "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net-next v1 1/1] ptp: ocp: Use DEFINE_RES_*() in place

On 21/12/2023 14:06, Andy Shevchenko wrote:
> There is no need to have an intermediate functions as DEFINE_RES_*()
> macros are represented by compound literals. Just use them in place.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>   drivers/ptp/ptp_ocp.c | 26 ++++++--------------------
>   1 file changed, 6 insertions(+), 20 deletions(-)
> 
> diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c
> index 4021d3d325f9..306353a69231 100644
> --- a/drivers/ptp/ptp_ocp.c
> +++ b/drivers/ptp/ptp_ocp.c
> @@ -1716,20 +1716,6 @@ ptp_ocp_get_mem(struct ptp_ocp *bp, struct ocp_resource *r)
>   	return __ptp_ocp_get_mem(bp, start, r->size);
>   }
>   
> -static void
> -ptp_ocp_set_irq_resource(struct resource *res, int irq)
> -{
> -	struct resource r = DEFINE_RES_IRQ(irq);
> -	*res = r;
> -}
> -
> -static void
> -ptp_ocp_set_mem_resource(struct resource *res, resource_size_t start, int size)
> -{
> -	struct resource r = DEFINE_RES_MEM(start, size);
> -	*res = r;
> -}
> -
>   static int
>   ptp_ocp_register_spi(struct ptp_ocp *bp, struct ocp_resource *r)
>   {
> @@ -1741,15 +1727,15 @@ ptp_ocp_register_spi(struct ptp_ocp *bp, struct ocp_resource *r)
>   	int id;
>   
>   	start = pci_resource_start(pdev, 0) + r->offset;
> -	ptp_ocp_set_mem_resource(&res[0], start, r->size);
> -	ptp_ocp_set_irq_resource(&res[1], pci_irq_vector(pdev, r->irq_vec));
> +	res[0] = DEFINE_RES_MEM(start, r->size);
> +	res[1] = DEFINE_RES_IRQ(pci_irq_vector(pdev, r->irq_vec));
>   
>   	info = r->extra;
>   	id = pci_dev_id(pdev) << 1;
>   	id += info->pci_offset;
>   
>   	p = platform_device_register_resndata(&pdev->dev, info->name, id,
> -					      res, 2, info->data,
> +					      res, ARRAY_SIZE(res), info->data,
>   					      info->data_size);
>   	if (IS_ERR(p))
>   		return PTR_ERR(p);
> @@ -1768,11 +1754,11 @@ ptp_ocp_i2c_bus(struct pci_dev *pdev, struct ocp_resource *r, int id)
>   
>   	info = r->extra;
>   	start = pci_resource_start(pdev, 0) + r->offset;
> -	ptp_ocp_set_mem_resource(&res[0], start, r->size);
> -	ptp_ocp_set_irq_resource(&res[1], pci_irq_vector(pdev, r->irq_vec));
> +	res[0] = DEFINE_RES_MEM(start, r->size);
> +	res[1] = DEFINE_RES_IRQ(pci_irq_vector(pdev, r->irq_vec));
>   
>   	return platform_device_register_resndata(&pdev->dev, info->name,
> -						 id, res, 2,
> +						 id, res, ARRAY_SIZE(res),
>   						 info->data, info->data_size);
>   }
>   

Thanks, Andy!

Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>