netdev - RE: [PATCH iwl-next v2] i40e: add trace events related to SFP module IOCTLs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ0PR11MB5866F6433F3140AEE2A23A07E595A@SJ0PR11MB5866.namprd11.prod.outlook.com>
Date: Thu, 21 Dec 2023 16:27:57 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: Simon Horman <horms@...nel.org>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>
Subject: RE: [PATCH iwl-next v2] i40e: add trace events related to SFP module
 IOCTLs



> -----Original Message-----
> From: Simon Horman <horms@...nel.org>
> Sent: Thursday, December 21, 2023 4:35 PM
> To: Loktionov, Aleksandr <aleksandr.loktionov@...el.com>
> Cc: intel-wired-lan@...ts.osuosl.org; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; netdev@...r.kernel.org; Kitszel,
> Przemyslaw <przemyslaw.kitszel@...el.com>
> Subject: Re: [PATCH iwl-next v2] i40e: add trace events related to
> SFP module IOCTLs
> 
> On Wed, Dec 20, 2023 at 06:38:37PM +0100, Aleksandr Loktionov
> wrote:
> > Add trace events related to SFP module IOCTLs for
> troubleshooting.
> >
> > Example:
> >         echo "i40e_*" >/sys/kernel/tracing/set_ftrace_filter
> >         echo "i40e_ioctl*"
> >/sys/kernel/tracing/events/i40e/filter
> >         echo 1  >/sys/kernel/tracing/tracing_on
> >         echo 1  >/sys/kernel/tracing/events/i40e/enable
> >         ...
> >         cat     /sys/kernel/tracing/trace
> >
> > Riewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> > Signed-off-by: Aleksandr Loktionov
> <aleksandr.loktionov@...el.com>
> > ---
> > v1->v2 applied to proper git branch
> > ---
> >  drivers/net/ethernet/intel/i40e/i40e_ethtool.c |  5 +++++
> >  drivers/net/ethernet/intel/i40e/i40e_trace.h   | 18
> ++++++++++++++++++
> >  2 files changed, 23 insertions(+)
> >
> > diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> > b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> > index c841779..bdf2b6b 100644
> > --- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> > +++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> > @@ -1074,6 +1074,7 @@ static int i40e_get_link_ksettings(struct
> net_device *netdev,
> >  	ethtool_link_ksettings_zero_link_mode(ks, supported);
> >  	ethtool_link_ksettings_zero_link_mode(ks, advertising);
> >
> > +	i40e_trace(ioctl_get_link_ksettings, pf, hw_link_info-
> >link_info);
> >  	if (link_up)
> >  		i40e_get_settings_link_up(hw, ks, netdev, pf);
> >  	else
> 
> Hi Aleksandr,
> 
> I think that i40e_trace.h needs to be included in i40e_ethtool.c as
> part of this patch.
> 
This patch is just needs to be applied after ' i40e: add tracepoints for nvmupdate troubleshooting' patch.


>  .../i40e_ethtool.c: In function ‘i40e_get_link_ksettings’:
>  .../i40e_ethtool.c:1077:9: error: implicit declaration of function
> ‘i40e_trace’ [-Werror=implicit-function-declaration]
>  1077 |         i40e_trace(ioctl_get_link_ksettings, pf,
> hw_link_info->link_info);
>       |         ^~~~~~~~~~
> 
> ...
> 
> Flagged by gcc-13 W=1 build
> 
> ...
> 
> --
> pw-bot: changes-requested