netdev - Re: [PATCH iproute2-next 01/20] bridge: vni: Accept 'del' command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZYRt2VCTVnGxI_1j@d3>
Date: Thu, 21 Dec 2023 11:54:49 -0500
From: Benjamin Poirier <bpoirier@...dia.com>
To: Stephen Hemminger <stephen@...workplumber.org>
Cc: netdev@...r.kernel.org, Petr Machata <petrm@...dia.com>,
	Roopa Prabhu <roopa@...dia.com>
Subject: Re: [PATCH iproute2-next 01/20] bridge: vni: Accept 'del' command

On 2023-12-21 08:06 -0800, Stephen Hemminger wrote:
> On Wed, 20 Dec 2023 19:57:08 -0800
> Stephen Hemminger <stephen@...workplumber.org> wrote:
> 
> > On Mon, 11 Dec 2023 09:07:13 -0500
> > Benjamin Poirier <bpoirier@...dia.com> wrote:
> > 
> > > `bridge vni help` shows "bridge vni { add | del } ..." but currently
> > > `bridge vni del ...` errors out unexpectedly:
> > > 	# bridge vni del
> > > 	Command "del" is unknown, try "bridge vni help".
> > > 
> > > Recognize 'del' as a synonym of the original 'delete' command.
> > > 
> > > Fixes: 45cd32f9f7d5 ("bridge: vxlan device vnifilter support")
> > > Reviewed-by: Petr Machata <petrm@...dia.com>
> > > Tested-by: Petr Machata <petrm@...dia.com>
> > > Signed-off-by: Benjamin Poirier <bpoirier@...dia.com>  
> > 
> > Please no.
> > We are blocking uses of matches() and now other commands will want more synonyms
> > Instead fix the help and doc.
> 
> I changed my mind. This is fine. The commands in iproute2 are inconsistent (no surprise)
> and plenty of places take del (and not delete??)

Indeed. Thank you for the update. In that case, can you take the series
as-is or should I still reduce the overall patch count and resubmit?