netdev - Re: [PATCH net-next v2 2/7] net: dsa: realtek: convert variants into real drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231221170837.mn4utavzesq3ahz7@skbuf>
Date: Thu, 21 Dec 2023 19:08:37 +0200
From: Vladimir Oltean <olteanv@...il.com>
To: Luiz Angelo Daros de Luca <luizluca@...il.com>
Cc: netdev@...r.kernel.org, linus.walleij@...aro.org, alsi@...g-olufsen.dk,
	andrew@...n.ch, f.fainelli@...il.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	arinc.unal@...nc9.com
Subject: Re: [PATCH net-next v2 2/7] net: dsa: realtek: convert variants into
 real drivers

On Wed, Dec 20, 2023 at 01:24:25AM -0300, Luiz Angelo Daros de Luca wrote:
> +static int rtl8365mb_init(void)
> +{
> +	int ret;
> +
> +	ret = realtek_mdio_driver_register(&rtl8365mb_mdio_driver);
> +	if (ret)
> +		return ret;
> +
> +	ret = platform_driver_register(&rtl8365mb_smi_driver);

I guess this was supposed to be a call to realtek_smi_driver_register().

> +	if (ret) {
> +		realtek_mdio_driver_unregister(&rtl8365mb_mdio_driver);
> +		return ret;
> +	}
> +
> +	return 0;
> +}
> +module_init(rtl8365mb_init);
> +
> +static void __exit rtl8365mb_exit(void)
> +{
> +	platform_driver_unregister(&rtl8365mb_smi_driver);

And this to realtek_smi_driver_unregister().

> +	realtek_mdio_driver_unregister(&rtl8365mb_mdio_driver);
> +}
> +module_exit(rtl8365mb_exit);