netdev - Re: [PATCH net-next v7 9/9] net: stmmac: Disable coe for some Loongson GNET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <axkfpgoyf2pd76k25563uzd5hfb5gsfr5cqlumn2gezai5xblj@h455tdgbogdh>
Date: Thu, 21 Dec 2023 05:36:38 +0300
From: Serge Semin <fancer.lancer@...il.com>
To: Yanteng Si <siyanteng@...ngson.cn>
Cc: andrew@...n.ch, hkallweit1@...il.com, peppe.cavallaro@...com, 
	alexandre.torgue@...s.st.com, joabreu@...opsys.com, Jose.Abreu@...opsys.com, 
	chenhuacai@...ngson.cn, linux@...linux.org.uk, guyinggang@...ngson.cn, 
	netdev@...r.kernel.org, chris.chenfeiyang@...il.com
Subject: Re: [PATCH net-next v7 9/9] net: stmmac: Disable coe for some
 Loongson GNET

On Tue, Dec 19, 2023 at 10:28:19PM +0800, Yanteng Si wrote:
> Some chips of Loongson GNET does not support coe, so disable them.
> 
> Signed-off-by: Yanteng Si <siyanteng@...ngson.cn>
> Signed-off-by: Feiyang Chen <chenfeiyang@...ngson.cn>
> Signed-off-by: Yinggang Gu <guyinggang@...ngson.cn>
> ---
>  drivers/net/ethernet/stmicro/stmmac/hwif.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/hwif.c b/drivers/net/ethernet/stmicro/stmmac/hwif.c
> index 3724cf698de6..f211880925aa 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/hwif.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/hwif.c
> @@ -73,6 +73,11 @@ static int stmmac_dwmac1_quirks(struct stmmac_priv *priv)
>  		mac->desc = &ndesc_ops;
>  	}
>  
> +	if (priv->synopsys_id == DWLGMAC_CORE_1_00) {
> +		priv->plat->tx_coe = 0;
> +		priv->plat->rx_coe = STMMAC_RX_COE_NONE;
> +	}

Couldn't this be done in dwmac-loongson.c?

-Serge(y)

> +
>  	stmmac_dwmac_mode_quirk(priv);
>  	return 0;
>  }
> -- 
> 2.31.4
>