netdev - RE: [PATCH iwl-net v4] i40e: Restore VF MSI-X state during PCI reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 21 Dec 2023 22:33:50 +0000
From: "Keller, Jacob E" <jacob.e.keller@...el.com>
To: "Staikov, Andrii" <andrii.staikov@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Ostrowska,
 Karen" <karen.ostrowska@...el.com>, Mateusz Palczewski
	<mateusz.palczewski@...el.com>, "Drewek, Wojciech"
	<wojciech.drewek@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>
Subject: RE: [PATCH iwl-net v4] i40e: Restore VF MSI-X state during PCI reset



> -----Original Message-----
> From: Staikov, Andrii <andrii.staikov@...el.com>
> Sent: Thursday, December 21, 2023 6:00 AM
> To: Keller, Jacob E <jacob.e.keller@...el.com>; intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Ostrowska, Karen
> <karen.ostrowska@...el.com>; Mateusz Palczewski
> <mateusz.palczewski@...el.com>; Drewek, Wojciech
> <wojciech.drewek@...el.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>
> Subject: RE: [PATCH iwl-net v4] i40e: Restore VF MSI-X state during PCI reset
> 
> 
> > The ice driver recently started caching the PCI device structure
> > pointers in their VF structure instead of having to do this sort of
> > lookup on the fly.
> >
> > See 31642d2854e2 ("ice: store VF's pci_dev ptr in ice_vf") [1][2]
> >
> > [1]:
> > https://lore.kernel.org/intel-wired-lan/20230912115626.105828-1-
> mateusz.polchlopek@...el.com/
> > [2]:
> > https://lore.kernel.org/netdev/20231019173227.3175575-4-
> jacob.e.keller@...el.com/
> >
> > Can we do something similar for i40e?
> 
> For now we don't anticipate much benefit of this approach, and we want relatively
> smaller change for a bugfix.
> 
> Regards,
> Staikov Andrii

Sure. If we ever need the VF PCI dev pointer in the future we can look into this. Not a huge deal for this since it’s the only place we use it currently anyways. Thanks for the response!

Thanks,
Jake