[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202312210853.t6DhuvdS-lkp@intel.com>
Date: Thu, 21 Dec 2023 08:41:54 +0800
From: kernel test robot <lkp@...el.com>
To: Luiz Angelo Daros de Luca <luizluca@...il.com>, netdev@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, linus.walleij@...aro.org,
alsi@...g-olufsen.dk, andrew@...n.ch, f.fainelli@...il.com,
olteanv@...il.com, davem@...emloft.net, edumazet@...gle.com,
kuba@...nel.org, pabeni@...hat.com, arinc.unal@...nc9.com,
Luiz Angelo Daros de Luca <luizluca@...il.com>
Subject: Re: [PATCH net-next v2 7/7] Revert "net: dsa: OF-ware slave_mii_bus"
Hi Luiz,
kernel test robot noticed the following build errors:
[auto build test ERROR on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Luiz-Angelo-Daros-de-Luca/net-dsa-realtek-drop-cleanup-from-realtek_ops/20231220-122907
base: net-next/main
patch link: https://lore.kernel.org/r/20231220042632.26825-8-luizluca%40gmail.com
patch subject: [PATCH net-next v2 7/7] Revert "net: dsa: OF-ware slave_mii_bus"
config: arm64-defconfig (https://download.01.org/0day-ci/archive/20231221/202312210853.t6DhuvdS-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231221/202312210853.t6DhuvdS-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312210853.t6DhuvdS-lkp@intel.com/
All errors (new ones prefixed by >>):
net/dsa/dsa.c: In function 'dsa_switch_setup':
>> net/dsa/dsa.c:667:60: error: macro "mdiobus_register" passed 2 arguments, but takes just 1
667 | err = mdiobus_register(ds->user_mii_bus, dn);
| ^
In file included from include/linux/of_net.h:9,
from net/dsa/dsa.c:18:
include/linux/phy.h:456: note: macro "mdiobus_register" defined here
456 | #define mdiobus_register(bus) __mdiobus_register(bus, THIS_MODULE)
|
>> net/dsa/dsa.c:667:23: error: 'mdiobus_register' undeclared (first use in this function); did you mean 'mdiobus_unregister'?
667 | err = mdiobus_register(ds->user_mii_bus, dn);
| ^~~~~~~~~~~~~~~~
| mdiobus_unregister
net/dsa/dsa.c:667:23: note: each undeclared identifier is reported only once for each function it appears in
vim +/mdiobus_register +667 net/dsa/dsa.c
625
626 static int dsa_switch_setup(struct dsa_switch *ds)
627 {
628 int err;
629
630 if (ds->setup)
631 return 0;
632
633 /* Initialize ds->phys_mii_mask before registering the user MDIO bus
634 * driver and before ops->setup() has run, since the switch drivers and
635 * the user MDIO bus driver rely on these values for probing PHY
636 * devices or not
637 */
638 ds->phys_mii_mask |= dsa_user_ports(ds);
639
640 err = dsa_switch_devlink_alloc(ds);
641 if (err)
642 return err;
643
644 err = dsa_switch_register_notifier(ds);
645 if (err)
646 goto devlink_free;
647
648 ds->configure_vlan_while_not_filtering = true;
649
650 err = ds->ops->setup(ds);
651 if (err < 0)
652 goto unregister_notifier;
653
654 err = dsa_switch_setup_tag_protocol(ds);
655 if (err)
656 goto teardown;
657
658 if (!ds->user_mii_bus && ds->ops->phy_read) {
659 ds->user_mii_bus = mdiobus_alloc();
660 if (!ds->user_mii_bus) {
661 err = -ENOMEM;
662 goto teardown;
663 }
664
665 dsa_user_mii_bus_init(ds);
666
> 667 err = mdiobus_register(ds->user_mii_bus, dn);
668 if (err < 0)
669 goto free_user_mii_bus;
670 }
671
672 dsa_switch_devlink_register(ds);
673
674 ds->setup = true;
675 return 0;
676
677 free_user_mii_bus:
678 if (ds->user_mii_bus && ds->ops->phy_read)
679 mdiobus_free(ds->user_mii_bus);
680 teardown:
681 if (ds->ops->teardown)
682 ds->ops->teardown(ds);
683 unregister_notifier:
684 dsa_switch_unregister_notifier(ds);
685 devlink_free:
686 dsa_switch_devlink_free(ds);
687 return err;
688 }
689
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists