lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231220195821.24a5ce3d@hermes.local>
Date: Wed, 20 Dec 2023 19:58:21 -0800
From: Stephen Hemminger <stephen@...workplumber.org>
To: Benjamin Poirier <bpoirier@...dia.com>
Cc: netdev@...r.kernel.org, Petr Machata <petrm@...dia.com>, Roopa Prabhu
 <roopa@...dia.com>
Subject: Re: [PATCH iproute2-next 02/20] bridge: vni: Remove dead code in
 group argument parsing

On Mon, 11 Dec 2023 09:07:14 -0500
Benjamin Poirier <bpoirier@...dia.com> wrote:

> is_addrtype_inet_not_multi(&daddr) may read an uninitialized "daddr". Even
> if that is fixed, the error message that follows cannot be reached because
> the situation would be caught by the previous test (group_present).
> Therefore, remove this test on daddr.
> 
> Fixes: 45cd32f9f7d5 ("bridge: vxlan device vnifilter support")
> Reviewed-by: Petr Machata <petrm@...dia.com>
> Tested-by: Petr Machata <petrm@...dia.com>
> Signed-off-by: Benjamin Poirier <bpoirier@...dia.com>
> ---
>  bridge/vni.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/bridge/vni.c b/bridge/vni.c
> index 6c0e35cd..33e50d18 100644
> --- a/bridge/vni.c
> +++ b/bridge/vni.c
> @@ -109,11 +109,6 @@ static int vni_modify(int cmd, int argc, char **argv)
>  		} else if (strcmp(*argv, "group") == 0) {
>  			if (group_present)
>  				invarg("duplicate group", *argv);
> -			if (is_addrtype_inet_not_multi(&daddr)) {
> -				fprintf(stderr, "vxlan: both group and remote");
> -				fprintf(stderr, " cannot be specified\n");
> -				return -1;
> -			}
>  			NEXT_ARG();
>  			get_addr(&daddr, *argv, AF_UNSPEC);
>  			if (!is_addrtype_inet_multi(&daddr))


This makes sense, and why was the message split in the first place.

Reviewed-by: Stephen Hemminger <stephen@...workplumber.org>

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ