netdev - Re: [PATCH iproute2-next 04/20] bridge: vni: Report duplicate vni argument using duparg()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231220195943.381072b1@hermes.local>
Date: Wed, 20 Dec 2023 19:59:43 -0800
From: Stephen Hemminger <stephen@...workplumber.org>
To: Benjamin Poirier <bpoirier@...dia.com>
Cc: netdev@...r.kernel.org, Petr Machata <petrm@...dia.com>, Roopa Prabhu
 <roopa@...dia.com>
Subject: Re: [PATCH iproute2-next 04/20] bridge: vni: Report duplicate vni
 argument using duparg()

On Mon, 11 Dec 2023 09:07:16 -0500
Benjamin Poirier <bpoirier@...dia.com> wrote:

> When there is a duplicate 'vni' option, report the error using duparg()
> instead of the generic invarg().
> 
> Before:
> $ bridge vni add vni 100 vni 101 dev vxlan2
> Error: argument "101" is wrong: duplicate vni
> 
> After:
> $ ./bridge/bridge vni add vni 100 vni 101 dev vxlan2
> Error: duplicate "vni": "101" is the second value.
> 
> Fixes: 45cd32f9f7d5 ("bridge: vxlan device vnifilter support")
> Reviewed-by: Petr Machata <petrm@...dia.com>
> Tested-by: Petr Machata <petrm@...dia.com>
> Signed-off-by: Benjamin Poirier <bpoirier@...dia.com>

Acked-by: Stephen Hemminger <stephen@...workplumber.org>