[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231220200447.5223fc98@hermes.local>
Date: Wed, 20 Dec 2023 20:04:47 -0800
From: Stephen Hemminger <stephen@...workplumber.org>
To: Benjamin Poirier <bpoirier@...dia.com>
Cc: netdev@...r.kernel.org, Petr Machata <petrm@...dia.com>, Roopa Prabhu
<roopa@...dia.com>
Subject: Re: [PATCH iproute2-next 07/20] bridge: vlan: Remove paranoid check
On Mon, 11 Dec 2023 09:07:19 -0500
Benjamin Poirier <bpoirier@...dia.com> wrote:
> To make the code lighter, remove the check on the actual print_range()
> output width. In the odd case that an out-of-range, wide vlan id is
> printed, printf() will treat the negative field width as positive and the
> output will simply be further misaligned.
>
> Suggested-by: Petr Machata <petrm@...dia.com>
> Reviewed-by: Petr Machata <petrm@...dia.com>
> Tested-by: Petr Machata <petrm@...dia.com>
> Signed-off-by: Benjamin Poirier <bpoirier@...dia.com>
Why truncate the output anyway?
Powered by blists - more mailing lists