netdev - Re: [PATCH] gmac: sun8i: r40: add gmac tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZYPmZj8l01eQsDS5@debian.cyg>
Date: Thu, 21 Dec 2023 15:16:54 +0800
From: fuyao <fuyao@...erm.com>
To: Jernej Škrabec <jernej.skrabec@...il.com>
Cc: Alexandre Torgue <alexandre.torgue@...s.st.com>,
	Jose Abreu <joabreu@...opsys.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Chen-Yu Tsai <wens@...e.org>, Samuel Holland <samuel@...lland.org>,
	Maxime Coquelin <mcoquelin.stm32@...il.com>, netdev@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
	linux-stm32@...md-mailman.stormreply.com,
	linux-kernel@...r.kernel.org,
	麦健建 <maijianzhang@...winnertech.com>
Subject: Re: [PATCH] gmac: sun8i: r40: add gmac tx_delay support

On Wed, Dec 20, 2023 at 06:04:28PM +0100, Jernej Škrabec wrote:
> Dne sreda, 20. december 2023 ob 10:08:25 CET je fuyao napisal(a):
> > r40 can support tx_delay, so we add it.
> 
> I don't see how. User manual, 3.3.4.64. GMAC Clock Register talks only
> about RX delay.
> 

I don't see it in the user manual also.

it works fine in 100M, but it doesn't work good in 1G without tx_delay
in my board.

Read the sdk from allwinner I found in:

https://sourcegraph.com/github.com/tinalinux/linux-3.10/-/blob/arch/arm/boot/dts/sun8iw11p1.dtsi?L1826
https://sourcegraph.com/github.com/tinalinux/linux-3.10@r40-v1.y/-/blob/drivers/net/ethernet/allwinner/sunxi-gmac.c?L877

And I add it to my board, it works fine.

So, I think it may be exist register but not documented.

Best regards,
fuyao

> Best regards,
> Jernej
> 
> > 
> > Signed-off-by: fuyao <fuyao1697@....com>
> > ---
> >  drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
> > index 137741b94122..fd07573afc9b 100644
> > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
> > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
> > @@ -127,6 +127,7 @@ static const struct emac_variant emac_variant_r40 = {
> >  	.support_mii = true,
> >  	.support_rgmii = true,
> >  	.rx_delay_max = 7,
> > +	.tx_delay_max = 7,
> >  };
> >  
> >  static const struct emac_variant emac_variant_a64 = {
> > 
> 
> 
> 
>