netdev - RE: [EXT] Re: [PATCH net-next v1 4/8] octeon_ep_vf: add Tx/Rx ring resource setup and cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 22 Dec 2023 16:33:18 +0000
From: Shinas Rasheed <srasheed@...vell.com>
To: Simon Horman <horms@...nel.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Haseeb Gani
	<hgani@...vell.com>, Vimlesh Kumar <vimleshk@...vell.com>,
        Sathesh B Edara
	<sedara@...vell.com>,
        "egallen@...hat.com" <egallen@...hat.com>,
        "mschmidt@...hat.com" <mschmidt@...hat.com>,
        "pabeni@...hat.com"
	<pabeni@...hat.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "wizhao@...hat.com"
	<wizhao@...hat.com>,
        "kheib@...hat.com" <kheib@...hat.com>,
        "konguyen@...hat.com" <konguyen@...hat.com>,
        Veerasenareddy Burru
	<vburru@...vell.com>,
        Satananda Burla <sburla@...vell.com>,
        "David S. Miller"
	<davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>
Subject: RE: [EXT] Re: [PATCH net-next v1 4/8] octeon_ep_vf: add Tx/Rx ring
 resource setup and cleanup

> Hi Shinas,
> 
> some minor feedback from my side which you might consider addressing
> if you have to respin the series for some other reason.
> 
+
> > +	oq->buff_info = (struct octep_vf_rx_buffer *)
> > +			vzalloc(oq->max_count *
> OCTEP_VF_OQ_RECVBUF_SIZE);
> 
> nit: There is no need to cast the return value of vzalloc()
> 
> 	oq->buff_info = vzalloc(oq->max_count *
> OCTEP_VF_OQ_RECVBUF_SIZE);
>>....
> > +	if (iq->buff_info)
> > +		vfree(iq->buff_info);
> 
> nit: vfree can handle a NULL argument, so  there is no need to protect it
>      with a if condition
> 

Thanks for the input. I'll wait for feedback from others a little while longer and then address these in the next version.