[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
<PH0PR18MB4734C94753260D2C92849419C794A@PH0PR18MB4734.namprd18.prod.outlook.com>
Date: Fri, 22 Dec 2023 16:33:18 +0000
From: Shinas Rasheed <srasheed@...vell.com>
To: Simon Horman <horms@...nel.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Haseeb Gani
<hgani@...vell.com>, Vimlesh Kumar <vimleshk@...vell.com>,
Sathesh B Edara
<sedara@...vell.com>,
"egallen@...hat.com" <egallen@...hat.com>,
"mschmidt@...hat.com" <mschmidt@...hat.com>,
"pabeni@...hat.com"
<pabeni@...hat.com>,
"kuba@...nel.org" <kuba@...nel.org>,
"wizhao@...hat.com"
<wizhao@...hat.com>,
"kheib@...hat.com" <kheib@...hat.com>,
"konguyen@...hat.com" <konguyen@...hat.com>,
Veerasenareddy Burru
<vburru@...vell.com>,
Satananda Burla <sburla@...vell.com>,
"David S. Miller"
<davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>
Subject: RE: [EXT] Re: [PATCH net-next v1 4/8] octeon_ep_vf: add Tx/Rx ring
resource setup and cleanup
> Hi Shinas,
>
> some minor feedback from my side which you might consider addressing
> if you have to respin the series for some other reason.
>
+
> > + oq->buff_info = (struct octep_vf_rx_buffer *)
> > + vzalloc(oq->max_count *
> OCTEP_VF_OQ_RECVBUF_SIZE);
>
> nit: There is no need to cast the return value of vzalloc()
>
> oq->buff_info = vzalloc(oq->max_count *
> OCTEP_VF_OQ_RECVBUF_SIZE);
>>....
> > + if (iq->buff_info)
> > + vfree(iq->buff_info);
>
> nit: vfree can handle a NULL argument, so there is no need to protect it
> with a if condition
>
Thanks for the input. I'll wait for feedback from others a little while longer and then address these in the next version.
Powered by blists - more mailing lists