netdev - Re: [PATCH net-next v2 5/7] net: dsa: realtek: Migrate user_mii

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 22 Dec 2023 23:59:29 +0300
From: Arınç ÜNAL <arinc.unal@...nc9.com>
To: Luiz Angelo Daros de Luca <luizluca@...il.com>
Cc: Alvin Šipraga <ALSI@...g-olufsen.dk>,
 Vladimir Oltean <olteanv@...il.com>,
 "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
 "andrew@...n.ch" <andrew@...n.ch>,
 "f.fainelli@...il.com" <f.fainelli@...il.com>,
 "davem@...emloft.net" <davem@...emloft.net>,
 "edumazet@...gle.com" <edumazet@...gle.com>,
 "kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com"
 <pabeni@...hat.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v2 5/7] net: dsa: realtek: Migrate user_mii_bus
 setup to realtek-dsa

Hey Luiz.

On 22.12.2023 23:28, Luiz Angelo Daros de Luca wrote:
>> I was speaking in the sense of all switches with CPU ports, which is
>> controlled by the DSA subsystem on Linux.
>>
>> I am only stating the fact that if we don't take the literal approach with
>> hardware descriptions on the driver implementation, there will always be
>> cases where the drivers will fail to support certain hardware designs.
> 
> Hi Arinç,
> 
> The old code was already requiring a single switch child node
> describing the internal MDIO bus akin to binding docs. I believe what
> we use to match it, being the name or the compatible string property,
> wouldn't improve the diversity of HW we could support. This series
> doesn't want to solve all issues and limitations nor prepare the
> ground for different HWs. It's mostly a reorganization without nice
> new stuff.
> 
> After this series, we could easily turn the mdio node optional,
> skipping the MDIO bus when not found. Anyway, if such HW appears just
> now, I believe we could simply workaround it by declaring an empty
> mdio node.

I agree that there's no need to add new things to this patch series. Just
address Vladimir's suggestions on the next version. You got into this
rabbit hole because you were just trying to add reset controller support on
the rtl8365mb driver, no? Geez!

Arınç