netdev - Re: [PATCH net-next v2 1/7] net: dsa: realtek: drop cleanup from realtek

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 22 Dec 2023 19:32:54 -0300
From: Luiz Angelo Daros de Luca <luizluca@...il.com>
To: Alvin Šipraga <ALSI@...g-olufsen.dk>
Cc: Vladimir Oltean <olteanv@...il.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, 
	"linus.walleij@...aro.org" <linus.walleij@...aro.org>, "andrew@...n.ch" <andrew@...n.ch>, 
	"f.fainelli@...il.com" <f.fainelli@...il.com>, "davem@...emloft.net" <davem@...emloft.net>, 
	"edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>, 
	"pabeni@...hat.com" <pabeni@...hat.com>, "arinc.unal@...nc9.com" <arinc.unal@...nc9.com>
Subject: Re: [PATCH net-next v2 1/7] net: dsa: realtek: drop cleanup from realtek_ops

> On Thu, Dec 21, 2023 at 07:04:18PM +0200, Vladimir Oltean wrote:
> > On Wed, Dec 20, 2023 at 01:57:41PM +0000, Alvin Šipraga wrote:
> > > On Wed, Dec 20, 2023 at 01:24:24AM -0300, Luiz Angelo Daros de Luca wrote:
> > > > It was never used and never referenced.
> > > >
> > > > Signed-off-by: Luiz Angelo Daros de Luca <luizluca@...il.com>
> > > > Reviewed-by: Alvin Šipraga <alsi@...g-olufsen.dk>
> > >
> > > You should always put your Signed-off-by last when sending patches.
> >
> > I'm not so sure about that.
> >
> > When you send a patch, it gets reviewed and then accepted all in the
> > same version, the Reviewed-by tag will be after your sign off. It makes
> > more sense to me that if you send a patch with a review tag carried
> > over, you put it in the same place where it would sit if it was received
> > on the final patch version. Idk, not too big of a deal.
>
> It's what I see most of the time, and Andrew recently pointed out the
> same [1]. Still there does not seem to be a consensus... [2] [3] [4]
>
> But yea, not a big deal!
>
> [1] https://lore.kernel.org/all/8d2dd95b-13f7-41d8-997f-d5c2953dcb06@lunn.ch/
> [2] https://lore.kernel.org/all/20200408073603.GA948@gerhold.net/
> [3] https://lore.kernel.org/all/20190627083443.4f4918a7@lwn.net/
> [4] https://lore.kernel.org/all/87a7zzd47q.fsf@intel.com/

I'll keep the original sequence. Normally, the last Signed-off-by is
the one that merged it, not the author.

Regards,

Luiz