netdev - Re: [PATCH net] selftests: bonding: do not set port down when adding to bond

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZYdlIskJQhAqkBvu@d3>
Date: Sat, 23 Dec 2023 17:54:26 -0500
From: Benjamin Poirier <benjamin.poirier@...il.com>
To: Hangbin Liu <liuhangbin@...il.com>
Cc: netdev@...r.kernel.org, Jay Vosburgh <jay.vosburgh@...onical.com>,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH net] selftests: bonding: do not set port down when adding
 to bond

On 2023-12-23 20:59 +0800, Hangbin Liu wrote:
> Similar to commit be809424659c ("selftests: bonding: do not set port down
> before adding to bond"). The bond-arp-interval-causes-panic test failed
> after commit a4abfa627c38 ("net: rtnetlink: Enslave device before bringing
> it up") as the kernel will set the port down _after_ adding to bond if setting
> port down specifically.
> 
> Fix it by removing the link down operation when adding to bond.
> 
> Fixes: 2ffd57327ff1 ("selftests: bonding: cause oops in bond_rr_gen_slave_id")
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---

Tested-by: Benjamin Poirier <benjamin.poirier@...il.com>