netdev - Re: [RFC PATCH net-next 00/10] selftests: Add TEST_INCLUDES directive and adjust tests to use it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZYaoDK6XZcR9C6r8@Laptop-X1>
Date: Sat, 23 Dec 2023 17:27:40 +0800
From: Hangbin Liu <liuhangbin@...il.com>
To: Benjamin Poirier <bpoirier@...dia.com>
Cc: netdev@...r.kernel.org, Shuah Khan <shuah@...nel.org>,
	Petr Machata <petrm@...dia.com>,
	Vladimir Oltean <vladimir.oltean@....com>
Subject: Re: [RFC PATCH net-next 00/10] selftests: Add TEST_INCLUDES
 directive and adjust tests to use it

On Fri, Dec 22, 2023 at 08:58:26AM -0500, Benjamin Poirier wrote:
> From: Benjamin Poirier <benjamin.poirier@...il.com>
> 
> After commit 25ae948b4478 ("selftests/net: add lib.sh"), some net
> selftests encounter errors when they are being exported and run. This is
> because the new net/lib.sh is not exported along with the tests.
> 
> After some related fixes to net selftests, this series introduces a new
> selftests Makefile variable to list extra files to export from other
> directories and makes use of it to resolve the errors described above.
> 
> Link: https://lore.kernel.org/netdev/ZXu7dGj7F9Ng8iIX@Laptop-X1/

Tested with

make TARGETS="drivers/net/team drivers/net/bonding drivers/net/dsa" \
        -j8 -C tools/testing/selftests gen_tar

and all looks good to me. Thanks for your works!

Tested-by: Hangbin Liu <liuhangbin@...il.com>
Reviewed-by: Hangbin Liu <liuhangbin@...il.com>