netdev - Re: [PATCH net-next 3/6] virtio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dc506381-1408-46b7-9be0-403f819cee38@linux.dev>
Date: Sun, 24 Dec 2023 16:55:08 +0800
From: Zhu Yanjun <yanjun.zhu@...ux.dev>
To: kernel test robot <lkp@...el.com>, Xuan Zhuo
 <xuanzhuo@...ux.alibaba.com>, netdev@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, "Michael S. Tsirkin" <mst@...hat.com>,
 Jason Wang <jasowang@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 virtualization@...ts.linux.dev
Subject: Re: [PATCH net-next 3/6] virtio_net: support device stats

在 2023/12/24 1:23, kernel test robot 写道:
> Hi Xuan,
> 
> kernel test robot noticed the following build warnings:
> 
> [auto build test WARNING on mst-vhost/linux-next]
> [also build test WARNING on linus/master v6.7-rc6]
> [cannot apply to net-next/main horms-ipvs/master next-20231222]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Xuan-Zhuo/virtio_net-introduce-device-stats-feature-and-structures/20231222-175505
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
> patch link:    https://lore.kernel.org/r/20231222033021.20649-4-xuanzhuo%40linux.alibaba.com
> patch subject: [PATCH net-next 3/6] virtio_net: support device stats
> config: arc-haps_hs_defconfig (https://download.01.org/0day-ci/archive/20231224/202312240155.ow7kvQZO-lkp@intel.com/config)
> compiler: arc-elf-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231224/202312240155.ow7kvQZO-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202312240155.ow7kvQZO-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
>     In file included from include/linux/virtio_net.h:8,
>                      from drivers/net/virtio_net.c:12:
>>> include/uapi/linux/virtio_net.h:419:45: warning: left shift count >= width of type [-Wshift-count-overflow]
>       419 | #define VIRTIO_NET_STATS_TYPE_CVQ       (1L << 32)
>           |                                             ^~
>     drivers/net/virtio_net.c:215:17: note: in expansion of macro 'VIRTIO_NET_STATS_TYPE_CVQ'
>       215 |                 VIRTIO_NET_STATS_TYPE_##TYPE,                   \
>           |                 ^~~~~~~~~~~~~~~~~~~~~~
>     drivers/net/virtio_net.c:224:9: note: in expansion of macro 'VIRTNET_DEVICE_STATS_MAP_ITEM'
>       224 |         VIRTNET_DEVICE_STATS_MAP_ITEM(CVQ, cvq, CQ),
>           |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> 
> vim +419 include/uapi/linux/virtio_net.h
> 
> ba106d1c676c80 Xuan Zhuo 2023-12-22  418
> ba106d1c676c80 Xuan Zhuo 2023-12-22 @419  #define VIRTIO_NET_STATS_TYPE_CVQ       (1L << 32)

#define VIRTIO_NET_STATS_TYPE_CVQ       (1ULL << 32)
The above can fix this problem.
Not sure whether this is appropriate for the whole patches.

Zhu Yanjun

> ba106d1c676c80 Xuan Zhuo 2023-12-22  420
>