lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20231225093608.GE5962@kernel.org> Date: Mon, 25 Dec 2023 09:36:08 +0000 From: Simon Horman <horms@...nel.org> To: Jesse Brandeburg <jesse.brandeburg@...el.com> Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org, aleksander.lobakin@...el.com, przemyslaw.kitszel@...el.com, marcin.szycik@...ux.intel.com Subject: Re: [PATCH iwl-next v2 01/15] e1000e: make lost bits explicit On Tue, Dec 05, 2023 at 05:01:00PM -0800, Jesse Brandeburg wrote: > For more than 15 years this code has passed in a request for a page and > masked off that page when read/writing. This code has been here forever, > but FIELD_PREP finds the bug when converted to use it. Change the code > to do exactly the same thing but allow the conversion to FIELD_PREP in a > later patch. To make it clear what we lost when making this change I > left a comment, but there is no point to change the code to generate a > correct sequence at this point. > > This is not a Fixes tagged patch on purpose because it doesn't change > the binary output. > > Reviewed-by: Marcin Szycik <marcin.szycik@...ux.intel.com> > Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com> Reviewed-by: Simon Horman <horms@...nel.org>
Powered by blists - more mailing lists