netdev - Re: [PATCH iwl-next v2 14/15] ice: cleanup inconsistent code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 25 Dec 2023 09:37:53 +0000
From: Simon Horman <horms@...nel.org>
To: Przemek Kitszel <przemyslaw.kitszel@...el.com>
Cc: Jesse Brandeburg <jesse.brandeburg@...el.com>,
	Kalesh Anakkur Purayil <kalesh-anakkur.purayil@...adcom.com>,
	intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
	aleksander.lobakin@...el.com, marcin.szycik@...ux.intel.com
Subject: Re: [PATCH iwl-next v2 14/15] ice: cleanup inconsistent code

On Thu, Dec 14, 2023 at 08:16:38AM +0100, Przemek Kitszel wrote:
> On 12/13/23 19:27, Jesse Brandeburg wrote:
> > Please don't use HTML email, your reply was likely dropped by most lists
> > that filter HTML.
> > 
> > On 12/12/2023 8:06 PM, Kalesh Anakkur Purayil wrote:
> > >      -       change_type = FIELD_GET(ICE_AQ_LLDP_MIB_TYPE_M,  mib->type);
> > >      +       change_type = FIELD_GET(ICE_AQ_LLDP_MIB_TYPE_M, mib->type);
> > > 
> > > [Kalesh]: I did not get what exactly changed here? Is that you just
> > > removed one extra space before mib->type?
> > 
> > Yes, there was a whitespace change missed in the GET series. I had
> > caught it only here. If you feel I need to I can resend to add a comment
> > to the commit message that this was added here.
> > 
> > 
> 
> I guess that NOT sending next revision is our only chance to fix this
> particular white space error ;)

It would be nice if there was a mechanism to fix such problems.

Regardless of this side topic, this patch looks good to me,
with or without the extra space removed.

Reviewed-by: Simon Horman <horms@...nel.org>