[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1996a76c.53ca7.18ca1ab27ca.Coremail.alexious@zju.edu.cn>
Date: Mon, 25 Dec 2023 23:49:57 +0800 (GMT+08:00)
From: alexious@....edu.cn
To: "Simon Horman" <horms@...nel.org>
Cc: "Chuck Lever" <chuck.lever@...cle.com>,
"Jeff Layton" <jlayton@...nel.org>, "Neil Brown" <neilb@...e.de>,
"Olga Kornievskaia" <kolga@...app.com>,
"Dai Ngo" <Dai.Ngo@...cle.com>, "Tom Talpey" <tom@...pey.com>,
"Trond Myklebust" <trond.myklebust@...merspace.com>,
"Anna Schumaker" <anna@...nel.org>,
"David S. Miller" <davem@...emloft.net>,
"Eric Dumazet" <edumazet@...gle.com>,
"Jakub Kicinski" <kuba@...nel.org>,
"Paolo Abeni" <pabeni@...hat.com>,
"J. Bruce Fields" <bfields@...ldses.org>,
"Simo Sorce" <simo@...hat.com>, linux-nfs@...r.kernel.org,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: Re: [PATCH] SUNRPC: fix some memleaks in gssx_dec_option_array
>
> On Sun, Dec 24, 2023 at 04:24:22PM +0800, Zhipeng Lu wrote:
> > The creds and oa->data need to be freed in the error-handling paths after
> > there allocation. So this patch add these deallocations in the
> > corresponding paths.
> >
> > Fixes: 1d658336b05f ("SUNRPC: Add RPC based upcall mechanism for RPCGSS auth")
> > Signed-off-by: Zhipeng Lu <alexious@....edu.cn>
>
> ...
>
> > diff --git a/net/sunrpc/auth_gss/gss_rpc_xdr.c b/net/sunrpc/auth_gss/gss_rpc_xdr.c
>
> ...
>
> > @@ -265,29 +265,41 @@ static int gssx_dec_option_array(struct xdr_stream *xdr,
> >
> > /* option buffer */
> > p = xdr_inline_decode(xdr, 4);
> > - if (unlikely(p == NULL))
> > - return -ENOSPC;
> > + if (unlikely(p == NULL)) {
> > + err = -ENOSPC
>
> Hi Zhipeng Lu,
>
> unfortunately the line above causes a build failure.
>
> ...
Sorry for my mistake, I'll send a version 2 of this patch soon.
Powered by blists - more mailing lists