netdev - Re: [PATCH net-next v2 02/13] bnxt_en: Add bnxt_l2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231225174446.GO5962@kernel.org>
Date: Mon, 25 Dec 2023 17:44:46 +0000
From: Simon Horman <horms@...nel.org>
To: Michael Chan <michael.chan@...adcom.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, pavan.chebbi@...adcom.com,
	andrew.gospodarek@...adcom.com
Subject: Re: [PATCH net-next v2 02/13] bnxt_en: Add bnxt_l2_filter hash table.

On Fri, Dec 22, 2023 at 08:21:59PM -0800, Michael Chan wrote:
> The current driver only has an array of 4 additional L2 unicast
> addresses to support the netdev uc address list.  Generalize and
> expand this infrastructure with an L2 address hash table so we can
> support an expanded list of unicast addresses (for bridges,
> macvlans, OVS, etc).  The L2 hash table infrastructure will also
> allow more generalized n-tuple filter support.
> 
> This patch creates the bnxt_l2_filter structure and the hash table.
> This L2 filter structure has the same bnxt_filter_base structure
> as used in the bnxt_ntuple_filter structure.
> 
> All currently supported L2 filters will now have an entry in this
> new table.
> 
> Note that L2 filters may be created for the VF.  VF filters should
> not be freed when the PF goes down.  Add some logic in
> bnxt_free_l2_filters() to allow keeping the VF filters or to free
> everything during rmmod.
> 
> Reviewed-by: Vasundhara Volam <vasundhara-v.volam@...adcom.com>
> Reviewed-by: Andy Gospodarek <andrew.gospodarek@...adcom.com>
> Reviewed-by: Pavan Chebbi <pavan.chebbi@...adcom.com>
> Signed-off-by: Michael Chan <michael.chan@...adcom.com>

Reviewed-by: Simon Horman <horms@...nel.org>