netdev - Re: [PATCH net-next] selftests/net: change the shebang of unicast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZYqSJk9rMxGxLx8s@yujie-X299>
Date: Tue, 26 Dec 2023 16:43:18 +0800
From: Yujie Liu <yujie.liu@...el.com>
To: Hangbin Liu <liuhangbin@...il.com>
CC: <netdev@...r.kernel.org>, Paolo Abeni <pabeni@...hat.com>, David Ahern
	<dsahern@...nel.org>, <linux-kselftest@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <lkp@...el.com>, kernel test robot
	<oliver.sang@...el.com>
Subject: Re: [PATCH net-next] selftests/net: change the shebang of
 unicast_extensions.sh to bash

Hi Hangbin,

On Mon, Dec 25, 2023 at 08:39:09PM +0800, Hangbin Liu wrote:
> On Mon, Dec 25, 2023 at 03:21:09PM +0800, Yujie Liu wrote:
> > The patch set [1] added a general lib.sh in net selftests, and converted
> > several test scripts to source the lib.sh.
> 
> Oh, I didn't know dash doesn't support "source". Thanks for the fix.
> Would you please also help fix the pmtu.sh, which has the same issue?

It looks like pmtu.sh was not converted in patch set [1], so it doesn't
have "source lib.sh" yet. The cover letter of [1] mentions that the
whole process of conversion will be split into several parts. Not sure
if pmtu.sh will be converted in the subsequent parts soon? If so, would
you like to change the shebang of pmtu.sh when converting it later, or
change it together in this patch? Thanks.

BTW, in addition to pmtu.sh, I noticed that there are several other
scripts in net selftests which have "/bin/sh" shebang:

linux/tools/testing/selftests/net$ grep -rF '#!/bin/sh'
openvswitch/openvswitch.sh:#!/bin/sh
in_netns.sh:#!/bin/sh
netdevice.sh:#!/bin/sh
test_bpf.sh:#!/bin/sh
test_blackhole_dev.sh:#!/bin/sh
vlan_hw_filter.sh:#!/bin/sh
run_netsocktests:#!/bin/sh
pmtu.sh:#!/bin/sh
bareudp.sh:#!/bin/sh
l2_tos_ttl_inherit.sh:#!/bin/sh
veth.sh:#!/bin/sh
ipv6_flowlabel.sh:#!/bin/sh
unicast_extensions.sh:#!/bin/sh
reuseport_addr_any.sh:#!/bin/sh
run_afpackettests:#!/bin/sh
ip_local_port_range.sh:#!/bin/sh
amt.sh:#!/bin/sh
udpgso.sh:#!/bin/sh
ip_defrag.sh:#!/bin/sh
rps_default_mask.sh:#!/bin/sh

> BTW, you can change the "source ./lib.sh" to "source lib.sh" to consistent
> with other tests.

Sure, will respin a v2 with this change added.

Thanks,
Yujie