netdev - RE: [PATCH v2] crypto: virtio - Less function calls in __virtio_crypto_akcipher_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <deb25ea00a57448d94496db1c46af693@huawei.com>
Date: Tue, 26 Dec 2023 12:22:11 +0000
From: "Gonglei (Arei)" <arei.gonglei@...wei.com>
To: Markus Elfring <Markus.Elfring@....de>, kernel test robot <lkp@...el.com>,
	"virtualization@...ts.linux.dev" <virtualization@...ts.linux.dev>,
	"linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>, "David
 S. Miller" <davem@...emloft.net>, Herbert Xu <herbert@...dor.apana.org.au>,
	Jason Wang <jasowang@...hat.com>, "Michael S. Tsirkin" <mst@...hat.com>,
	"Xuan Zhuo" <xuanzhuo@...ux.alibaba.com>
CC: "llvm@...ts.linux.dev" <llvm@...ts.linux.dev>,
	"oe-kbuild-all@...ts.linux.dev" <oe-kbuild-all@...ts.linux.dev>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, LKML
	<linux-kernel@...r.kernel.org>, "cocci@...ia.fr" <cocci@...ia.fr>
Subject: RE: [PATCH v2] crypto: virtio - Less function calls in
 __virtio_crypto_akcipher_do_req() after error detection



> -----Original Message-----
> From: Markus Elfring [mailto:Markus.Elfring@....de]
> Sent: Tuesday, December 26, 2023 6:12 PM
> To: kernel test robot <lkp@...el.com>; virtualization@...ts.linux.dev;
> linux-crypto@...r.kernel.org; kernel-janitors@...r.kernel.org; David S. Miller
> <davem@...emloft.net>; Gonglei (Arei) <arei.gonglei@...wei.com>; Herbert
> Xu <herbert@...dor.apana.org.au>; Jason Wang <jasowang@...hat.com>;
> Michael S. Tsirkin <mst@...hat.com>; Xuan Zhuo
> <xuanzhuo@...ux.alibaba.com>
> Cc: llvm@...ts.linux.dev; oe-kbuild-all@...ts.linux.dev; netdev@...r.kernel.org;
> LKML <linux-kernel@...r.kernel.org>; cocci@...ia.fr
> Subject: [PATCH v2] crypto: virtio - Less function calls in
> __virtio_crypto_akcipher_do_req() after error detection
> 
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Tue, 26 Dec 2023 11:00:20 +0100
> 
> The kfree() function was called in up to two cases by the
> __virtio_crypto_akcipher_do_req() function during error handling even if the
> passed variable contained a null pointer.
> This issue was detected by using the Coccinelle software.
> 
> * Adjust jump targets.
> 
> * Delete two initialisations which became unnecessary
>   with this refactoring.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
> 
> v2:
> A typo was fixed for the delimiter of a label.
> 
>  drivers/crypto/virtio/virtio_crypto_akcipher_algs.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 

Reviewed-by: Gonglei <arei.gonglei@...wei.com>


Regards,
-Gonglei