netdev - Re: [RFC PATCH net-next 05/10] selftests: Introduce Makefile variable to list shared bash scripts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231227194700.zqhod5nbn6bibub3@skbuf>
Date: Wed, 27 Dec 2023 21:47:00 +0200
From: Vladimir Oltean <vladimir.oltean@....com>
To: Benjamin Poirier <bpoirier@...dia.com>
Cc: netdev@...r.kernel.org, Shuah Khan <shuah@...nel.org>,
	Petr Machata <petrm@...dia.com>, Hangbin Liu <liuhangbin@...il.com>
Subject: Re: [RFC PATCH net-next 05/10] selftests: Introduce Makefile
 variable to list shared bash scripts

On Wed, Dec 27, 2023 at 09:43:56PM +0200, Vladimir Oltean wrote:
> On Fri, Dec 22, 2023 at 08:58:31AM -0500, Benjamin Poirier wrote:
> > diff --git a/Documentation/dev-tools/kselftest.rst b/Documentation/dev-tools/kselftest.rst
> > index ab376b316c36..8b79843ca514 100644
> > --- a/Documentation/dev-tools/kselftest.rst
> > +++ b/Documentation/dev-tools/kselftest.rst
> > @@ -255,9 +255,15 @@ Contributing new tests (details)
> >  
> >     TEST_PROGS_EXTENDED, TEST_GEN_PROGS_EXTENDED mean it is the
> >     executable which is not tested by default.
> > +
> >     TEST_FILES, TEST_GEN_FILES mean it is the file which is used by
> >     test.
> >  
> > +   TEST_INCLUDES lists files which are not in the current directory or one of
> > +   its descendants but which should be included when exporting or installing
> > +   the tests. The files are listed with a path relative to
> > +   tools/testing/selftests/.
> > +
> >   * First use the headers inside the kernel source and/or git repo, and then the
> >     system headers.  Headers for the kernel release as opposed to headers
> >     installed by the distro on the system should be the primary focus to be able
> 
> I've never had to touch this infrastructure, but the fact that TEST_INCLUDES
> is relative to tools/testing/selftests/ when all other TEST_* variables
> are relative to $PWD seems ... inconsistent?

To solve the inconsistency, can it be used like this everywhere?

TEST_INCLUDES := \
	$(SRC_PATH)/net/lib.sh

(I haven't tried this)