netdev - Re: [PATCH net 1/2] netfilter: nf_tables: set transport offset from mac header for netdev/egress

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <170383682580.6676.16830645380063126929.git-patchwork-notify@kernel.org>
Date: Fri, 29 Dec 2023 08:00:25 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Pablo Neira Ayuso <pablo@...filter.org>
Cc: netfilter-devel@...r.kernel.org, davem@...emloft.net,
 netdev@...r.kernel.org, kuba@...nel.org, pabeni@...hat.com,
 edumazet@...gle.com, fw@...len.de
Subject: Re: [PATCH net 1/2] netfilter: nf_tables: set transport offset from mac
 header for netdev/egress

Hello:

This series was applied to netdev/net.git (main)
by Pablo Neira Ayuso <pablo@...filter.org>:

On Fri, 22 Dec 2023 11:42:04 +0100 you wrote:
> Before this patch, transport offset (pkt->thoff) provides an offset
> relative to the network header. This is fine for the inet families
> because skb->data points to the network header in such case. However,
> from netdev/egress, skb->data points to the mac header (if available),
> thus, pkt->thoff is missing the mac header length.
> 
> Add skb_network_offset() to the transport offset (pkt->thoff) for
> netdev, so transport header mangling works as expected. Adjust payload
> fast eval function to use skb->data now that pkt->thoff provides an
> absolute offset. This explains why users report that matching on
> egress/netdev works but payload mangling does not.
> 
> [...]

Here is the summary with links:
  - [net,1/2] netfilter: nf_tables: set transport offset from mac header for netdev/egress
    https://git.kernel.org/netdev/net/c/0ae8e4cca787
  - [net,2/2] netfilter: nf_tables: skip set commit for deleted/destroyed sets
    https://git.kernel.org/netdev/net/c/7315dc1e122c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html