netdev - Re: [PATCH v3] net: bcmgenet: Fix FCS generation for fragmented skbuffs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86765ca8-11e3-4de4-a111-1ef00720571c@broadcom.com>
Date: Fri, 29 Dec 2023 09:51:38 +0100
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Adrian Cinal <adriancinal1@...il.com>, netdev@...r.kernel.org
Cc: opendmb@...il.com, bcm-kernel-feedback-list@...adcom.com,
 Adrian Cinal <adriancinal@...il.com>
Subject: Re: [PATCH v3] net: bcmgenet: Fix FCS generation for fragmented
 skbuffs



On 12/28/2023 2:56 PM, Adrian Cinal wrote:
> From: Adrian Cinal <adriancinal@...il.com>
> 
> The flag DMA_TX_APPEND_CRC was only written to the first DMA descriptor
> in the TX path, where each descriptor corresponds to a single skbuff
> fragment (or the skbuff head). This led to packets with no FCS appearing
> on the wire if the kernel allocated the packet in fragments, which would
> always happen when using PACKET_MMAP/TPACKET (cf. tpacket_fill_skb() in
> net/af_packet.c).
> 
> Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file")
> Signed-off-by: Adrian Cinal <adriancinal1@...il.com>

Acked-by: Florian Fainelli <florian.fainelli@...adcom.com>
-- 
Florian

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4221 bytes)