lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <873097b9-5a0b-495b-83ae-f2247fbb512b@web.de> Date: Sun, 31 Dec 2023 11:33:19 +0100 From: Markus Elfring <Markus.Elfring@....de> To: linux-wireless@...r.kernel.org, netdev@...r.kernel.org, kernel-janitors@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Johannes Berg <johannes@...solutions.net>, Paolo Abeni <pabeni@...hat.com> Cc: LKML <linux-kernel@...r.kernel.org> Subject: [PATCH] wifi: cfg80211: Replace a label in cfg80211_parse_ml_sta_data() From: Markus Elfring <elfring@...rs.sourceforge.net> Date: Sun, 31 Dec 2023 11:22:42 +0100 The kfree() function was called in one case by the cfg80211_parse_ml_sta_data() function during error handling even if the passed variable contained a null pointer. This issue was detected by using the Coccinelle software. Thus use an other label. Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net> --- net/wireless/scan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/wireless/scan.c b/net/wireless/scan.c index cf2131671eb6..492e30138418 100644 --- a/net/wireless/scan.c +++ b/net/wireless/scan.c @@ -2693,7 +2693,7 @@ static void cfg80211_parse_ml_sta_data(struct wiphy *wiphy, new_ie = kmalloc(IEEE80211_MAX_DATA_LEN, gfp); if (!new_ie) - goto out; + goto free_mle; for (i = 0; i < ARRAY_SIZE(mle->sta_prof) && mle->sta_prof[i]; i++) { const struct ieee80211_neighbor_ap_info *ap_info; @@ -2812,8 +2812,8 @@ static void cfg80211_parse_ml_sta_data(struct wiphy *wiphy, cfg80211_put_bss(wiphy, bss); } -out: kfree(new_ie); +free_mle: kfree(mle); } -- 2.43.0
Powered by blists - more mailing lists