lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <477e5649-87e3-44d9-8226-010b9822e649@web.de> Date: Sun, 31 Dec 2023 18:42:30 +0100 From: Markus Elfring <Markus.Elfring@....de> To: netdev@...r.kernel.org, kernel-janitors@...r.kernel.org, Anjali Kulkarni <anjali.k.kulkarni@...cle.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Kuniyuki Iwashima <kuniyu@...zon.com>, Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org> Cc: LKML <linux-kernel@...r.kernel.org> Subject: [PATCH 1/4] netlink: Improve exception handling in __netlink_kernel_create() From: Markus Elfring <elfring@...rs.sourceforge.net> Date: Sun, 31 Dec 2023 17:26:41 +0100 The kfree() function was called in one case by the __netlink_kernel_create() function during error handling even if the passed variable contained a null pointer. This issue was detected by using the Coccinelle software. Thus use another label. Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net> --- net/netlink/af_netlink.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index 4ed8ffd58ff3..c3f88015cacf 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c @@ -2042,7 +2042,7 @@ __netlink_kernel_create(struct net *net, int unit, struct module *module, listeners = kzalloc(sizeof(*listeners) + NLGRPSZ(groups), GFP_KERNEL); if (!listeners) - goto out_sock_release; + goto out_netlink_release_sock; sk->sk_data_ready = netlink_data_ready; if (cfg && cfg->input) @@ -2076,6 +2076,7 @@ __netlink_kernel_create(struct net *net, int unit, struct module *module, out_sock_release: kfree(listeners); +out_netlink_release_sock: netlink_kernel_release(sk); return NULL; -- 2.43.0
Powered by blists - more mailing lists