lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231231144421.13ba1d04@hermes.local>
Date: Sun, 31 Dec 2023 14:44:21 -0800
From: Stephen Hemminger <stephen@...workplumber.org>
To: Markus Elfring <Markus.Elfring@....de>
Cc: netdev@...r.kernel.org, kernel-janitors@...r.kernel.org, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub
 Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Willem de
 Bruijn <willemdebruijn.kernel@...il.com>, LKML
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] packet: Improve exception handling in fanout_add()

On Sun, 31 Dec 2023 16:39:02 +0100
Markus Elfring <Markus.Elfring@....de> wrote:

> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Sun, 31 Dec 2023 16:30:51 +0100
> 
> The kfree() function was called in some cases by the fanout_add() function
> even if the passed variable contained a null pointer.
> This issue was detected by using the Coccinelle software.
> 
> Thus use another label.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

NAK
kfree of null is perfectly fine. 
There is no need for this patch.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ