[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 1 Jan 2024 22:28:50 +0100
From: Heiner Kallweit <hkallweit1@...il.com>
To: Andrew Lunn <andrew@...n.ch>, Russell King <rmk+kernel@...linux.org.uk>,
David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: [PATCH net-next 5/5] net: phy: c45: extend
genphy_c45_ethtool_[set|get]_eee
Extend both functions to use the linkmode bitmap extension if available.
Note: The linkmode extension for now is supported only if ethtool uses
netlink. It's not supported for ioctl.
Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
---
drivers/net/phy/phy-c45.c | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c
index 9d8b2b5eb..e276dba19 100644
--- a/drivers/net/phy/phy-c45.c
+++ b/drivers/net/phy/phy-c45.c
@@ -1454,6 +1454,7 @@ int genphy_c45_ethtool_get_eee(struct phy_device *phydev,
__ETHTOOL_DECLARE_LINK_MODE_MASK(adv) = {};
__ETHTOOL_DECLARE_LINK_MODE_MASK(lp) = {};
bool overflow = false, is_enabled;
+ struct ethtool_keee *keee;
int ret;
ret = genphy_c45_eee_is_active(phydev, adv, lp, &is_enabled);
@@ -1463,6 +1464,16 @@ int genphy_c45_ethtool_get_eee(struct phy_device *phydev,
data->eee_enabled = is_enabled;
data->eee_active = ret;
+ keee = ethtool_eee2keee(data);
+ if (keee) {
+ linkmode_copy(keee->link_modes.supported,
+ phydev->supported_eee);
+ linkmode_copy(keee->link_modes.advertising, adv);
+ linkmode_copy(keee->link_modes.lp_advertising, lp);
+ keee->use_link_modes = 1;
+ return 0;
+ }
+
if (!ethtool_convert_link_mode_to_legacy_u32(&data->supported,
phydev->supported_eee))
overflow = true;
@@ -1494,6 +1505,7 @@ int genphy_c45_ethtool_set_eee(struct phy_device *phydev,
{
__ETHTOOL_DECLARE_LINK_MODE_MASK(adv);
__ETHTOOL_DECLARE_LINK_MODE_MASK(tmp);
+ struct ethtool_keee *keee;
bool unsupported;
int ret;
@@ -1501,7 +1513,11 @@ int genphy_c45_ethtool_set_eee(struct phy_device *phydev,
if (!data->eee_enabled)
goto eee_aneg;
- ethtool_convert_legacy_u32_to_link_mode(adv, data->advertised);
+ keee = ethtool_eee2keee(data);
+ if (keee && keee->use_link_modes)
+ linkmode_copy(adv, keee->link_modes.advertising);
+ else
+ ethtool_convert_legacy_u32_to_link_mode(adv, data->advertised);
if (linkmode_empty(adv)) {
linkmode_copy(phydev->advertising_eee, phydev->supported_eee);
--
2.43.0
Powered by blists - more mailing lists