netdev - RE: [EXT] [net-next: PATCH] net: mvpp2: initialize port fwnode pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: 
 <SJ0PR18MB5216B68CF41CA2DA540DF979DB61A@SJ0PR18MB5216.namprd18.prod.outlook.com>
Date: Tue, 2 Jan 2024 06:35:37 +0000
From: Suman Ghosh <sumang@...vell.com>
To: Marcin Wojtas <marcin.s.wojtas@...il.com>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
CC: "andriy.shevchenko@...ux.intel.com" <andriy.shevchenko@...ux.intel.com>,
        "olteanv@...il.com" <olteanv@...il.com>,
        "davem@...emloft.net"
	<davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "linux@...linux.org.uk"
	<linux@...linux.org.uk>
Subject: RE: [EXT] [net-next: PATCH] net: mvpp2: initialize port fwnode
 pointer

Looks good to me.

>----------------------------------------------------------------------
>Update the port's device structure also with its fwnode pointer with a
>recommended device_set_node() helper routine.
>
>Signed-off-by: Marcin Wojtas <marcin.s.wojtas@...il.com>
[Suman] Reviewed-by: Suman Ghosh <sumang@...vell.com>
>---
> drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
>b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
>index 1ca273f17d29..820b1fabe297 100644
>--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
>+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
>@@ -6877,7 +6877,7 @@ static int mvpp2_port_probe(struct platform_device
>*pdev,
> 	dev->min_mtu = ETH_MIN_MTU;
> 	/* 9704 == 9728 - 20 and rounding to 8 */
> 	dev->max_mtu = MVPP2_BM_JUMBO_PKT_SIZE;
>-	dev->dev.of_node = port_node;
>+	device_set_node(&dev->dev, port_fwnode);
>
> 	port->pcs_gmac.ops = &mvpp2_phylink_gmac_pcs_ops;
> 	port->pcs_gmac.neg_mode = true;
>--
>2.34.1
>